[llvm] r201625 - Now that llvm always does the right thing with private, use it.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Feb 19 07:24:42 PST 2014


On 19 February 2014 09:51, Alexander Potapenko <glider at google.com> wrote:
> Rafael, did you run `make check-asan` on Darwin?
> projects/compiler-rt/test/asan/TestCases/Darwin/asan_gen_prefixes.cc
> fails for me now, because it's looking for an "l"-prefixed global in
> __TEXT,__const, but ASan makes it an "L"-prefixed one.
> According to http://llvm.org/bugs/show_bug.cgi?id=17976#c10 it's not correct.

No, I assumed that any tests for the pass would be in llvm itself.

The idea is that now we produce a private linkage, but llvm will then
produce an 'l' label for it. I am running check-asan now.

Cheers,
Rafael



More information about the llvm-commits mailing list