[PATCH] Schedule discriminators pass.
Diego Novillo
dnovillo at google.com
Tue Feb 18 14:05:23 PST 2014
This adds two additional changes required by the discriminator
pass:
1- Add discriminator argument when calling DIBuilder::createLexicalBlock.
2- Modify line table test to account for new lexical block created to
support the new discriminator value.
Hi echristo,
http://llvm-reviews.chandlerc.com/D2692
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D2692?vs=6994&id=7183#toc
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/linetable-eh.cpp
Index: lib/CodeGen/BackendUtil.cpp
===================================================================
--- lib/CodeGen/BackendUtil.cpp
+++ lib/CodeGen/BackendUtil.cpp
@@ -165,6 +165,11 @@
PM.add(createSampleProfileLoaderPass(CGOpts.SampleProfileFile));
}
+static void addAddDiscriminatorsPass(const PassManagerBuilder &Builder,
+ PassManagerBase &PM) {
+ PM.add(createAddDiscriminatorsPass());
+}
+
static void addBoundsCheckingPass(const PassManagerBuilder &Builder,
PassManagerBase &PM) {
PM.add(createBoundsCheckingPass());
@@ -245,6 +250,9 @@
PMBuilder.DisableUnrollLoops = !CodeGenOpts.UnrollLoops;
PMBuilder.RerollLoops = CodeGenOpts.RerollLoops;
+ PMBuilder.addExtension(PassManagerBuilder::EP_EarlyAsPossible,
+ addAddDiscriminatorsPass);
+
if (!CodeGenOpts.SampleProfileFile.empty())
PMBuilder.addExtension(PassManagerBuilder::EP_EarlyAsPossible,
addSampleProfileLoaderPass);
Index: lib/CodeGen/CGDebugInfo.cpp
===================================================================
--- lib/CodeGen/CGDebugInfo.cpp
+++ lib/CodeGen/CGDebugInfo.cpp
@@ -2577,7 +2577,8 @@
llvm::DIDescriptor(LexicalBlockStack.back()),
getOrCreateFile(CurLoc),
getLineNumber(CurLoc),
- getColumnNumber(CurLoc));
+ getColumnNumber(CurLoc),
+ 0);
llvm::MDNode *DN = D;
LexicalBlockStack.push_back(DN);
}
Index: test/CodeGenCXX/linetable-eh.cpp
===================================================================
--- test/CodeGenCXX/linetable-eh.cpp
+++ test/CodeGenCXX/linetable-eh.cpp
@@ -6,15 +6,16 @@
// CHECK: call void @llvm.dbg.declare
// CHECK: call void @llvm.dbg.declare(metadata !{{{.*}}}, metadata ![[CURRENT_ADDR:.*]]), !dbg ![[DBG1:.*]]
// CHECK: unwind label %{{.*}}, !dbg ![[DBG1]]
-// CHECK: store i64 %{{.*}}, i64* %current_address, align 8, !dbg ![[DBG1]]
+// CHECK: store i64 %{{.*}}, i64* %current_address, align 8, !dbg ![[DBG4:.*]]
// CHECK-NEXT: call void @llvm.dbg.declare(metadata !{{{.*}}}, metadata ![[FOUND_IT:.*]]), !dbg ![[DBG2:.*]]
// CHECK: = landingpad
// CHECK-NEXT: cleanup, !dbg ![[DBG3:.*]]
// CHECK-DAG: ![[CURRENT_ADDR]] = {{.*}} [current_address]
// CHECK-DAG: ![[FOUND_IT]] = {{.*}} [found_it]
// CHECK-DAG: ![[DBG1]] = metadata !{i32 256,
// CHECK-DAG: ![[DBG2]] = metadata !{i32 257,
// CHECK-DAG: ![[DBG3]] = metadata !{i32 268,
+// CHECK-DAG: ![[DBG4]] = metadata !{i32 256,
typedef unsigned long long uint64_t;
template<class _Tp> class shared_ptr {
public:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2692.3.patch
Type: text/x-patch
Size: 2752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140218/e3b22ecc/attachment.bin>
More information about the llvm-commits
mailing list