[llvm] r201277 - The new MCJIT C-API unit test is generating objects without constant data

[Lang Hames]

Thanks for catching this Eli and Takumi,

Fixed by removing the tautological check in r201451.

- Lang.

On Thu, Feb 13, 2014 at 9:58 AM, Eli Bendersky <eliben at google.com> wrote:
> Lang, this change adds compile warnings on gcc 4.8 since you compare an
> unsigned >= 0 (tautology)
>
> Eli
>
>
> On Wed, Feb 12, 2014 at 4:16 PM, Lang Hames <lhames at gmail.com> wrote:
>>
>> Author: lhames
>> Date: Wed Feb 12 18:16:36 2014
>> New Revision: 201277
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=201277&view=rev
>> Log:
>> The new MCJIT C-API unit test is generating objects without constant data
>> sections, at least on MachO. Relax expectations to keep the bots green
>> while I
>> investigate.
>>
>>
>> Modified:
>>     llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
>>
>> Modified: llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp?rev=201277&r1=201276&r2=201277&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
>> (original)
>> +++ llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp Wed Feb
>> 12 18:16:36 2014
>> @@ -322,6 +322,6 @@ TEST_F(MCJITCAPITest, reserve_allocation
>>    EXPECT_LE(MM->UsedDataSizeRO, MM->ReservedDataSizeRO);
>>    EXPECT_LE(MM->UsedDataSizeRW, MM->ReservedDataSizeRW);
>>    EXPECT_TRUE(MM->UsedCodeSize > 0);
>> -  EXPECT_TRUE(MM->UsedDataSizeRO > 0);
>> +  EXPECT_TRUE(MM->UsedDataSizeRO >= 0);
>>    EXPECT_TRUE(MM->UsedDataSizeRW > 0);
>>  }
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>