[llvm] r201444 - DwarfUnit: Remove unnecessarily explicit/out of line virtual dtors.

David Blaikie dblaikie at gmail.com
Fri Feb 14 14:50:59 PST 2014


Author: dblaikie
Date: Fri Feb 14 16:50:59 2014
New Revision: 201444

URL: http://llvm.org/viewvc/llvm-project?rev=201444&view=rev
Log:
DwarfUnit: Remove unnecessarily explicit/out of line virtual dtors.

These types have an out of line virtual function each (emitHeader at
least) so they won't have weak vtables - no need for more than that.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=201444&r1=201443&r2=201444&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Fri Feb 14 16:50:59 2014
@@ -1979,8 +1979,6 @@ void DwarfUnit::emitHeader(const MCSecti
   Asm->EmitInt8(Asm->getDataLayout().getPointerSize());
 }
 
-DwarfCompileUnit::~DwarfCompileUnit() {}
-
 void DwarfCompileUnit::initStmtList(MCSymbol *DwarfLineSectionSym) {
   // Define start line table label for each Compile Unit.
   MCSymbol *LineTableStartSym =
@@ -2007,8 +2005,6 @@ void DwarfCompileUnit::initStmtList(MCSy
                     DwarfLineSectionSym);
 }
 
-DwarfTypeUnit::~DwarfTypeUnit() {}
-
 void DwarfTypeUnit::emitHeader(const MCSection *ASection,
                                const MCSymbol *ASectionSym) const {
   DwarfUnit::emitHeader(ASection, ASectionSym);

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h?rev=201444&r1=201443&r2=201444&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h Fri Feb 14 16:50:59 2014
@@ -542,7 +542,6 @@ class DwarfCompileUnit : public DwarfUni
 public:
   DwarfCompileUnit(unsigned UID, DIE *D, DICompileUnit Node, AsmPrinter *A,
                    DwarfDebug *DW, DwarfFile *DWU);
-  virtual ~DwarfCompileUnit() LLVM_OVERRIDE;
 
   void initStmtList(MCSymbol *DwarfLineSectionSym);
 
@@ -565,7 +564,6 @@ private:
 public:
   DwarfTypeUnit(unsigned UID, DIE *D, DwarfCompileUnit &CU, AsmPrinter *A,
                 DwarfDebug *DW, DwarfFile *DWU);
-  virtual ~DwarfTypeUnit() LLVM_OVERRIDE;
 
   void setTypeSignature(uint64_t Signature) { TypeSignature = Signature; }
   uint64_t getTypeSignature() const { return TypeSignature; }





More information about the llvm-commits mailing list