[PATCH] building lnt tools to test cross-compiling

[Daniel Dunbar]

On Thu, Feb 13, 2014 at 2:15 PM, Robert Lytton <robert at xmos.com> wrote:

>  Hi Daniel,
>
>      ifdef USER_MODE_EMULATION
>>   RUNSAFELY := $(RUNSAFELY) -t "$(TIMEIT)"
>>   else
>>   RUNSAFELY := $(RUNSAFELY) -t "$(TIMEIT_TARGET)"
>>   endif
>>
> > You forgot to also look at where TIMEIT is used, which includes this
> line:
> > RUNSAFELYLOCAL := $(RUNSAFELYLOCAL) --show-errors -t "$(TIMEIT)"
> > With USER_MODE_EMULATION off, both can be used.
>
> Quite right, my mistake, I originally had:
>
>   -all:: timeit timeit-target fpcmp TargetConfig.mk
>   +ifdef USER_MODE_EMULATION
>   +all:: timeit fpcmp TargetConfig.mk
>   +else
>   +all:: timeit timeit-target fpcmp TargetConfig.mk
>   +endif
>
> Would this be acceptable?
>

This is ok, but I think it can be more cleanly written as:
--
 all:: timeit fpcmp TargetConfig.mk

# Avoid depending on timeit-target if it is not needed, some targets that
use emulation cannot build it.
ifndef USER_MODE_EMULATION
all:: timeit-target
--

   - Daniel

Would ' timeit-target' ever be run on an emulator?
> I'm trying to understand how remote testing and the use of an emulator
> would combine...
>
> Robert
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140214/4e8c2976/attachment.html>