[PATCH] Use an 'l' prefix when an 'L' prefix would produce an invalid MachO

kledzik at apple.com kledzik at apple.com
Thu Feb 13 14:49:39 PST 2014



================
Comment at: test/CodeGen/PowerPC/osx-private-labels.ll:1
@@ +1,2 @@
+; RUN: llc < %s -mtriple=powerpc-apple-darwin | FileCheck %s
+; Test all the cases where a L label is safe. Removing any entry from
----------------
powerpc is not an architecture that is actively used and tested for mach-o.   x86_64 would be better.

================
Comment at: test/CodeGen/PowerPC/osx-private-labels.ll:70
@@ +69,2 @@
+; CHECK-NEXT: .align	2
+; CHECK-NEXT: L_private12:
----------------
Shouldn't there also be test which *do* get changed into 'l' labels?

================
Comment at: test/CodeGen/PowerPC/osx-private-labels.ll:10-14
@@ +9,7 @@
+
+ at private2 = private unnamed_addr constant [5 x i16] [i16 116, i16 101,
+                                                     i16 115, i16 116, i16 0]
+; CHECK: .section	__TEXT,__ustring
+; CHECK-NEXT: .align	1
+; CHECK-NEXT: L_private2:
+
----------------
The __ustring section does need labels for the linker to see. 


http://llvm-reviews.chandlerc.com/D2727



More information about the llvm-commits mailing list