[PATCH] Fix generation of 'isa' and 'discriminator' keywords.

Eric Christopher echristo at gmail.com
Thu Feb 13 12:20:35 PST 2014


Yep.

-eric

On Thu, Feb 13, 2014 at 12:20 PM, Diego Novillo <dnovillo at google.com> wrote:
> On Thu, Feb 13, 2014 at 3:14 PM, Eric Christopher <echristo at gmail.com> wrote:
>> Just call llvm-mc once and use CHECK. Since you aren't passing any
>> additional options you don't need multiple run lines.
>
> Ah. Like this?
>
> diff --git a/test/MC/AsmParser/directive_loc.s
> b/test/MC/AsmParser/directive_loc.s
> index 5a24ae9..cda9579 100644
> --- a/test/MC/AsmParser/directive_loc.s
> +++ b/test/MC/AsmParser/directive_loc.s
> @@ -1,18 +1,14 @@
> -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
> -check-prefix=FILE
> -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
> -check-prefix=BASIC-LOC-1
> -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
> -check-prefix=BASIC-LOC-2
> -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
> -check-prefix=DISCRIMINATOR
> -# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=ISA
> +# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s
>
>          .file 1 "hello"
> -# FILE: .file 1 "hello"
> +# CHECK: .file 1 "hello"
>          .loc 1
>          .loc 1 2
> -# BASIC-LOC-1: .loc 1 2 0
> +# CHECK: .loc 1 2 0
>          .loc 1 2 3
> -# BASIC-LOC-2: .loc 1 2 3
> +# CHECK: .loc 1 2 3
>          .loc 1 2 discriminator 1
> -# DISCRIMINATOR: 1 2 0 discriminator 1
> +# CHECK: 1 2 0 discriminator 1
>          .loc 1 2 0 isa 3
> -# ISA: 1 2 0 isa 3
> +# CHECK: 1 2 0 isa 3
>          .loc 1 0



More information about the llvm-commits mailing list