[PATCH] building lnt tools to test cross-compiling

[Daniel Dunbar]

On Thu, Feb 13, 2014 at 7:36 AM, robert lytton <robert at xmos.com> wrote:

> Hi rafael,
>
> Hi
>
> At present LNT builds the tools 'timeit' & 'timeit-target'.
> However, it seems only one will be used, depending if USER_MODE_EMULATION
> as be defined or not viz:
>

This is not true, when building for remote testing, timeit will be used to
run timing on the host (like the compile commands), and timeit-target will
be used to time on the remote device.



>
> Makefile.rules
>   TIMEIT        = $(PROJ_OBJ_ROOT)/tools/timeit
>   TIMEIT_TARGET = $(PROJ_OBJ_ROOT)/tools/timeit-target
>
> Makefile.programs
>   ifdef USER_MODE_EMULATION
>   RUNSAFELY := $(RUNSAFELY) -t "$(TIMEIT)"
>   else
>   RUNSAFELY := $(RUNSAFELY) -t "$(TIMEIT_TARGET)"
>   endif
>

You forgot to also look at where TIMEIT is used, which includes this line:
RUNSAFELYLOCAL := $(RUNSAFELYLOCAL) --show-errors -t "$(TIMEIT)"

With USER_MODE_EMULATION off, both can be used.

 - Daniel


>
> The patch is needed as the unused 'timeit-target' won't build when passed
> the $(TARGET_FLAGS) for xcore, causing an error.
>
> Thank you
> Robert
>
>
> http://llvm-reviews.chandlerc.com/D2766
>
> Files:
>   tools/Makefile
>
> Index: tools/Makefile
> ===================================================================
> --- tools/Makefile
> +++ tools/Makefile
> @@ -1,7 +1,11 @@
>  LEVEL=..
>  include $(LEVEL)/Makefile.programs
>
> -all:: timeit timeit-target fpcmp TargetConfig.mk
> +ifdef USER_MODE_EMULATION
> +all:: timeit fpcmp TargetConfig.mk
> +else
> +all:: timeit-target fpcmp TargetConfig.mk
> +endif
>
>  timeit: timeit.c
>         $(ORIGINAL_CC) $(CFLAGS) -O3 -o $@ $<
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140213/e9e7a71d/attachment.html>