Patch: Extract initialization of TargetOptions from CodeGen flags

Eli Bendersky eliben at google.com
Thu Feb 13 10:27:17 PST 2014


The same code (~20 lines) for initializing a TargetOptions object from
CodeGen cmdline flags is duplicated 4 (yes 4) times in 4 different tools.
This patch moves it into a utility function.

Since the CodeGen/CommandFlags.h file defines cl::opt flags *in a header*,
it's a bit of a touchy situation because we should only link them into
tools. So this patch puts the init function in the header. Ideas for
something better are most welcome!

PTAL
Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140213/799db09f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: refactor-targetoptions-init.1.patch
Type: text/x-patch
Size: 10396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140213/799db09f/attachment.bin>


More information about the llvm-commits mailing list