[patch] Verify that a GlobalAlias has no section or alignment.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Feb 13 08:39:10 PST 2014


On 13 February 2014 00:30, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> On 12 February 2014 22:23, Reid Kleckner <rnk at google.com> wrote:
>> lgtm, assuming this passes an optimized build of something interesting.
>>
>> Should we go further and assert(!isa<GlobalAlias>(this) || S.empty()); in
>> GlobalValue::setSection?
>
> Good point. I can't imagine why some pass would want to set this even
> temporarily. We cannot use isa on the header because GlobalAlias is
> incomplete there. What do you think of the attached patch? I will try
> a clang bootstrap with it tomorrow.

This passed the bootstrap.

Cheers,
Rafael




More information about the llvm-commits mailing list