[PATCH] Android test runner for ASan lit tests

Alexey Samsonov samsonov at google.com
Thu Feb 13 08:07:23 PST 2014


  LGTM with nits.


================
Comment at: lib/asan/lit_tests/GenericConfig/lit.site.cfg.in:8
@@ +7,3 @@
+config.target_cflags = "@ASAN_TEST_TARGET_CFLAGS@"
+config.clang = "@ASAN_TEST_TARGET_CC@"
+config.llvm_tools_dir = "@ASAN_TEST_LLVM_TOOLS_DIR@"
----------------
If ASAN_TEST_TARGET_CC is undefined, will this work properly (i.e., will config.clang be set lit.common.configured)?

================
Comment at: lib/asan/lit_tests/android_commands/android_run.py:26
@@ +25,3 @@
+device_exitcode = device_binary + '.exitcode'
+# zz = os.fdopen(tempfile.mkstemp(prefix='lsof_', dir='/tmp/z')[0], 'w')
+# subprocess.call(['adb', 'shell', 'lsof 2>&1'], stdout=zz, stderr=subprocess.STDOUT)
----------------
remove debugging lines

================
Comment at: lib/asan/lit_tests/lit.cfg:67
@@ +66,3 @@
+  config.available_features.add('android')
+  clang_wrapper = config.compiler_rt_src_root + "/lib/asan/lit_tests/android_commands/android_compile.py "
+else:
----------------
use config.asan_source_dir here, maybe with os.path.join.


http://llvm-reviews.chandlerc.com/D2698



More information about the llvm-commits mailing list