[PATCH] Add a new pass to compute DWARF path discriminators.

[Eric Christopher]

On Wed, Feb 12, 2014 at 6:40 AM, Diego Novillo <dnovillo at google.com> wrote:
> On Tue, Feb 11, 2014 at 10:38 PM, Eric Christopher <echristo at gmail.com> wrote:
>>
>>   Seems like a reasonable start. I think it'd be good to start looking at breaking things out. The pass and then everything else (though some of the
>> everything else can be split out into separate patches as well). Otherwise tests and documentation changes for the individual patches and it's
>> probably good to go.
>
> OK. I'll figure out how the tests work and add a few. So,
>
> - Patch with just the pass plus tests.
> - Patch for object streamer to write discriminator information plus tests.
>
> Anything else you want split?

The MCAsmStreamer.cpp bit can be committed separately as well. Don't
forget to change the metadata documentation in
SourceLevelDebugging.html to account for the change in the lexical
block format to add discriminators. The rest of it looks like it
logically works together (i.e. the pass and the context/DIBuilder
changes are one set).

Don't forget to test that parsing .loc directives with discriminator
information works and outputs correctly. Also there should be some
dumping support in lib/DebugInfo to go with the object streamer work.

Thanks!

-eric