[PATCH] Build fix for lib/Support/Path.cpp
David Fang
fang at csl.cornell.edu
Tue Feb 11 14:06:13 PST 2014
> On 11 February 2014 16:49, David Fang <fang at csl.cornell.edu> wrote:
>> Hi all,
>> Indeed, I have that section #ifdef'd out in my patchsets for
>> powerpc-darwin8 (lib/Support/Path.cpp):
>
> I think we can go with Dave's patch. It is fairly simple and should
> have no impact in current versions of OS X. What do you think?
I test the same patchsets on less-than-ancient darwin as well, and it
causes no breakage on modern OS X.
Dave's patch is functionally the same as what I have, so LGTM.
I just have a comment in my patch that says where those defines are
expected on darwin:
// macros expected in <unistd.h>
David
> Cheers,
> Rafael
>
--
David Fang
http://www.csl.cornell.edu/~fang/
More information about the llvm-commits
mailing list