[PATCH] Add a new pass to compute DWARF path discriminators.
Diego Novillo
dnovillo at google.com
Tue Feb 11 09:05:21 PST 2014
This update fixes the failures I was getting before. Instead of
modifying the DILexicalBlock after creation, I've changed
DIBuilder::createLexicalBlock to accept a discriminator value. This
seems cleaner as well.
I suppose that when I was mutating the block, this was invalidating
some caching done by the MDNode machinery? I'm not really sure what
was happening.
With this I get no ICEs, but I still don't seem to fully get
discriminators all the way down to the executable. Is there any other
place for me to look at?
Hi echristo,
http://llvm-reviews.chandlerc.com/D2691
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D2691?vs=6967&id=6993#toc
Files:
include/llvm/DIBuilder.h
include/llvm/DebugInfo.h
include/llvm/InitializePasses.h
include/llvm/Transforms/Scalar.h
lib/CodeGen/AsmPrinter/DwarfDebug.cpp
lib/IR/DIBuilder.cpp
lib/IR/DebugInfo.cpp
lib/IR/LLVMContextImpl.h
lib/MC/MCObjectStreamer.cpp
lib/Transforms/Scalar/SampleProfile.cpp
lib/Transforms/Utils/AddDiscriminators.cpp
lib/Transforms/Utils/CMakeLists.txt
lib/Transforms/Utils/Utils.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2691.4.patch
Type: text/x-patch
Size: 15967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140211/7b813b7c/attachment.bin>
More information about the llvm-commits
mailing list