[PATCH] AArch64 sanitizer support

Alexander Potapenko glider at google.com
Tue Feb 11 02:36:29 PST 2014



================
Comment at: libsanitizer/sanitizer_common/sanitizer_linux.cc:96
@@ -95,1 +95,3 @@
 uptr internal_open(const char *filename, int flags) {
+#ifdef __aarch64__
+  return internal_syscall(__NR_openat, AT_FDCWD, (uptr)filename, flags);
----------------
Christophe Lyon wrote:
> Kostya Serebryany wrote:
> > OMG, these ifdefs again... 
> > What is so special about AArch64 that it needs other syscalls
> > (where ARM/PowerPC/SPARC/MIPS doesn't need them)?
> > If there is no way to avoid these ifdefs, they at least deserve a top-level comment in this file. 
> > 
> I discussed that a while ago with AArch64 maintainers, here is what they said:
> 
> > The AArch64 linux port uses the canonical syscall set as mandated by
> > the upstream linux community for all new ports.  The system calls are
> > not missing, rather, other architectures are using legacy syscalls ;-)
> 
> 
Is there a list of such syscalls somewhere? We'd better use them on every platform then.


http://llvm-reviews.chandlerc.com/D2732



More information about the llvm-commits mailing list