[PATCH] AArch64 sanitizer support

[Renato Golin]

On 11 February 2014 05:11, Kostya Serebryany <kcc at google.com> wrote:
>   This patch is obviously based on the GCC source tree, LLVM source does not have 'libsanitizer' directory or a file configure.tgt.
>   Let me give the first round of comments here, but then please send another patch based on the LLMV tree.

Hi Kostya,

Yes, he said so in the first email. ;)

First of all, thanks for your detailed review, we shall continue that on phab.

After my email to the GCC list trying to get some cooperation going, I
think this is a good moment to get some rules for GCC contributions to
the sanitizers.

AFAIU, they have a separate three, which merges from our tree every so
often. The work they do there, unlike Christophe's patch, is mainly
around making it compile with GCC.

If their tree is "identical" to ours (modulo GCC stuff), than it
should be simple to just apply the patch on LLVM's tree.

I'm guessing something like this:

1. Develop, test in GCC's sanitizer tree
2. Take a diff one directory up (to avoid "libsanitizer")
3. Apply the patch on an LLVM sanitizer's tree (inside compiler-rt)
and re-work the build to LLVM style.
4. Test (now, this is the hard part for new archs, but we're biting that bullet)
5. Submit the patch to LLVM's tree via Phab
6. Commit to compiler-rt
7. Merge back into libsanitizer

Steps 3 and 4 above are the hard ones and one we'll have to help in
some way. Maybe buildbots would help, but for new archs, it will come
after the first patches. I'm sure we'll find a way and lets get that
documented somewhere, so at least we make it easier for other
toolchains to use our libraries. ;)

Makes sense?

cheers,
--renato