LTO API: add lto_module_create_from_memory_with_path.

[Manman Ren]

On Mon, Feb 10, 2014 at 7:44 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 7 February 2014 18:06, Manman Ren <manman.ren at gmail.com> wrote:
> >
> > Hi all,
> >
> > This function adds an extra path argument to
> lto_module_create_from_memory.
> > The path argument will be passed to makeBuffer to make sure the
> MemoryBuffer
> > has a name and the created module has a module identifier. Modules
> created
> > by lto_module_create_from_memory will have empty module identifiers.
> >
> > This is mainly for emitting warning messages from the linker. When we
> emit
> > warning message on one module, we can then use its module identifier.
> >
> > LTO_API_VERSION is bumped to 9.
>
>
> +  /// makeBuffer -
>
> While at it, please remove the function name from the comment.
>
> -                                  std::string &errMsg);
> +                                  std::string &errMsg, const char *path =
> "");
>
> The C++ files should probably use a StringRef.
>

Thanks Rafael for reviewing the patch. Committed at r201114 with fixes
addressing the above.

Manman


>
> LGTM with that.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140210/b71b0bad/attachment.html>