[compiler-rt] r200482 - Add an /FS flag to the lib/interception CMake to make it buildable with VS2013 too

Hans Wennborg hwennborg at google.com
Mon Feb 10 15:12:58 PST 2014


This just bit me.

Do we want to bump the "cmake_minimum_required" version in
compiler-rt's CMakeLists.txt to 2.8.12.1?

 - Hans

On Fri, Jan 31, 2014 at 10:31 AM, Timur Iskhodzhanov
<timurrrr at google.com> wrote:
> Ah, thanks for the pointer!
> That explains why I wasn't able to reproduce it on my newer workstation with
> a fresh CMake.
>
> I've removed /FS in r200564.
>
>
> 2014-01-30 Brad King <brad.king at kitware.com>:
>
>> On 1/30/2014 2:53 PM, Timur Iskhodzhanov wrote:
>> > Good idea, done in r200485
>> >
>> >
>> > 2014-01-30 Alexey Samsonov:
>> >
>> >     Does it make sense to add -FS/ to SANITIZER_COMMON_FLAGS instead?
>>
>> FYI, CMake 2.8.12.1 was released just after VS 2013 in order
>> to add /FS as part of the generation process:
>>
>>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=216afc8a
>>
>> It should be automatic with that version of CMake and higher.
>>
>> -Brad
>
>



More information about the llvm-commits mailing list