[llvm] r201113 - Mark the methods in the Mangler const.
Rafael Espindola
rafael.espindola at gmail.com
Mon Feb 10 13:25:13 PST 2014
Author: rafael
Date: Mon Feb 10 15:25:13 2014
New Revision: 201113
URL: http://llvm.org/viewvc/llvm-project?rev=201113&view=rev
Log:
Mark the methods in the Mangler const.
A const ObjectFile needs to be able to provide its name. For an IRObjectFile,
that means being able to call the mangler. Since each IRObjectFile can have
a different mangling, it is natural for them to contain a Mangler which is
therefore also const.
Modified:
llvm/trunk/include/llvm/IR/Mangler.h
llvm/trunk/lib/IR/Mangler.cpp
Modified: llvm/trunk/include/llvm/IR/Mangler.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Mangler.h?rev=201113&r1=201112&r2=201113&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/Mangler.h (original)
+++ llvm/trunk/include/llvm/IR/Mangler.h Mon Feb 10 15:25:13 2014
@@ -39,11 +39,11 @@ private:
/// they are mangled. This keeps track of the number we give to anonymous
/// ones.
///
- DenseMap<const GlobalValue*, unsigned> AnonGlobalIDs;
+ mutable DenseMap<const GlobalValue*, unsigned> AnonGlobalIDs;
/// NextAnonGlobalID - This simple counter is used to unique value names.
///
- unsigned NextAnonGlobalID;
+ mutable unsigned NextAnonGlobalID;
public:
Mangler(const DataLayout *DL) : DL(DL), NextAnonGlobalID(1) {}
@@ -51,15 +51,16 @@ public:
/// Print the appropriate prefix and the specified global variable's name.
/// If the global variable doesn't have a name, this fills in a unique name
/// for the global.
- void getNameWithPrefix(raw_ostream &OS, const GlobalValue *GV);
- void getNameWithPrefix(SmallVectorImpl<char> &OutName, const GlobalValue *GV);
+ void getNameWithPrefix(raw_ostream &OS, const GlobalValue *GV) const;
+ void getNameWithPrefix(SmallVectorImpl<char> &OutName,
+ const GlobalValue *GV) const;
/// Print the appropriate prefix and the specified name as the global variable
/// name. GVName must not be empty.
void getNameWithPrefix(raw_ostream &OS, const Twine &GVName,
- ManglerPrefixTy PrefixTy = Mangler::Default);
+ ManglerPrefixTy PrefixTy = Mangler::Default) const;
void getNameWithPrefix(SmallVectorImpl<char> &OutName, const Twine &GVName,
- ManglerPrefixTy PrefixTy = Mangler::Default);
+ ManglerPrefixTy PrefixTy = Mangler::Default) const;
};
} // End llvm namespace
Modified: llvm/trunk/lib/IR/Mangler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Mangler.cpp?rev=201113&r1=201112&r2=201113&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Mangler.cpp (original)
+++ llvm/trunk/lib/IR/Mangler.cpp Mon Feb 10 15:25:13 2014
@@ -44,13 +44,14 @@ static void getNameWithPrefixx(raw_ostre
OS << Name;
}
-void Mangler::getNameWithPrefix(raw_ostream &OS,
- const Twine &GVName, ManglerPrefixTy PrefixTy) {
+void Mangler::getNameWithPrefix(raw_ostream &OS, const Twine &GVName,
+ ManglerPrefixTy PrefixTy) const {
return getNameWithPrefixx(OS, GVName, PrefixTy, *DL, false);
}
void Mangler::getNameWithPrefix(SmallVectorImpl<char> &OutName,
- const Twine &GVName, ManglerPrefixTy PrefixTy) {
+ const Twine &GVName,
+ ManglerPrefixTy PrefixTy) const {
raw_svector_ostream OS(OutName);
return getNameWithPrefix(OS, GVName, PrefixTy);
}
@@ -75,7 +76,7 @@ static void AddFastCallStdCallSuffix(raw
OS << '@' << ArgWords;
}
-void Mangler::getNameWithPrefix(raw_ostream &OS, const GlobalValue *GV) {
+void Mangler::getNameWithPrefix(raw_ostream &OS, const GlobalValue *GV) const {
ManglerPrefixTy PrefixTy = Mangler::Default;
if (GV->hasPrivateLinkage())
PrefixTy = Mangler::Private;
@@ -133,7 +134,7 @@ void Mangler::getNameWithPrefix(raw_ostr
}
void Mangler::getNameWithPrefix(SmallVectorImpl<char> &OutName,
- const GlobalValue *GV) {
+ const GlobalValue *GV) const {
raw_svector_ostream OS(OutName);
getNameWithPrefix(OS, GV);
}
More information about the llvm-commits
mailing list