[llvm] r201008 - [Constant Hoisting] Don't update the use list while traversing it - DOH!

[Juergen Ributzka]

Author: ributzka
Date: Fri Feb  7 18:20:45 2014
New Revision: 201008

URL: http://llvm.org/viewvc/llvm-project?rev=201008&view=rev
Log:
[Constant Hoisting] Don't update the use list while traversing it - DOH!

This fix first traverses the whole use list of the constant expression and
keeps track of the instructions that need to be updated. Then perform the
fixup afterwards.

Modified:
    llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp?rev=201008&r1=201007&r2=201008&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/ConstantHoisting.cpp Fri Feb  7 18:20:45 2014
@@ -350,14 +350,19 @@ void ConstantHoisting::EmitBaseConstants
   }
   assert(isa<ConstantExpr>(U) && "Expected a ConstantExpr.");
   ConstantExpr *CE = cast<ConstantExpr>(U);
+  SmallVector<std::pair<Instruction *, Instruction *>, 8> WorkList;
+  DEBUG(dbgs() << "Visit ConstantExpr " << *CE << '\n');
   for (Value::use_iterator UU = CE->use_begin(), E = CE->use_end();
        UU != E; ++UU) {
+    DEBUG(dbgs() << "Check user "; UU->print(dbgs()); dbgs() << '\n');
     // We only handel instructions here and won't walk down a ConstantExpr chain
     // to replace all ConstExpr with instructions.
     if (Instruction *I = dyn_cast<Instruction>(*UU)) {
       // Only update constant expressions in the current function.
-      if (I->getParent()->getParent() != &F)
+      if (I->getParent()->getParent() != &F) {
+        DEBUG(dbgs() << "Not in the same function - skip.\n");
         continue;
+      }
 
       Instruction *Mat = Base;
       Instruction *InsertBefore = getMatInsertPt(I, DT);
@@ -380,12 +385,18 @@ void ConstantHoisting::EmitBaseConstants
       // Use the same debug location as the instruction we are about to update.
       ICE->setDebugLoc(I->getDebugLoc());
 
-      DEBUG(dbgs() << "Create instruction: " << *ICE << '\n');
-      DEBUG(dbgs() << "Update: " << *I << '\n');
-      I->replaceUsesOfWith(CE, ICE);
-      DEBUG(dbgs() << "To: " << *I << '\n');
+      WorkList.push_back(std::make_pair(I, ICE));
+    } else {
+      DEBUG(dbgs() << "Not an instruction - skip.\n");
     }
   }
+  SmallVectorImpl<std::pair<Instruction *, Instruction *> >::iterator I, E;
+  for (I = WorkList.begin(), E = WorkList.end(); I != E; ++I) {
+    DEBUG(dbgs() << "Create instruction: " << *I->second << '\n');
+    DEBUG(dbgs() << "Update: " << *I->first << '\n');
+    I->first->replaceUsesOfWith(CE, I->second);
+    DEBUG(dbgs() << "To: " << *I->first << '\n');
+  }
 }
 
 /// \brief Hoist and hide the base constant behind a bitcast and emit