[PATCH] [lld][core] sectionGroup support.

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu Feb 6 10:34:01 PST 2014


  Forgot to add the test to the diff, I will add the test and upload an updated patch.


================
Comment at: lib/Core/SymbolTable.cpp:193
@@ +192,3 @@
+      findSignature(*existingMember, visitedSet);
+  assert((signatureAtom == *groupSignature) &&
+         "Signature for group and the existing signature point to different "
----------------
Simon Atanasyan wrote:
> I get the following compiler error on this line:
> 
>    SymbolTable.cpp:193:25: error: invalid operands to binary expression ('const lld::DefinedAtom' and 'const lld::DefinedAtom')
I was thinking why my build didnt show up this error, looks like I dont have asserts enabled in my build.

Will fix.


http://llvm-reviews.chandlerc.com/D2710



More information about the llvm-commits mailing list