[PATCH] Demote EmitRawText call in AsmPrinter::EmitInlineAsm() and remove hasRawTextSupport() call

Daniel Sanders daniel.sanders at imgtec.com
Thu Feb 6 02:54:34 PST 2014


  - Moved the predicates to MCAsmInfo.
  - Implemented all (except one) of clangs conditions for whether -integrated-as
    is the default.
    - A couple conditions have imperfect conversions. For example testing for
      MachO output has become testing for Darwin.
    - getOS() == Solaris, is currently missing. There doesn't seem to be a good
      place to put it.
  - Dropped the word 'Inline' from variables and option names. If this code is
    going to be unified with clang's logic then it will cover inline and
    non-inline asm.

Hi rafael,

http://llvm-reviews.chandlerc.com/D2686

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2686?vs=6854&id=6917#toc

Files:
  include/llvm/MC/MCAsmInfo.h
  test/Transforms/BranchFolding/2007-10-19-InlineAsmDirectives.ll
  test/CodeGen/X86/2010-07-13-indirectXconstraint.ll
  test/CodeGen/X86/cas.ll
  test/CodeGen/X86/fast-isel.ll
  test/CodeGen/X86/2007-03-24-InlineAsmVectorOp.ll
  test/CodeGen/X86/mult-alt-x86.ll
  test/CodeGen/X86/2010-05-05-LocalAllocEarlyClobber.ll
  test/CodeGen/X86/2009-04-13-2AddrAssert-2.ll
  test/CodeGen/X86/2009-05-08-InlineAsmIOffset.ll
  test/CodeGen/X86/2010-06-28-matched-g-constraint.ll
  test/CodeGen/X86/mult-alt-generic-x86_64.ll
  test/CodeGen/X86/ms-inline-asm.ll
  test/CodeGen/X86/2008-10-17-Asm64bitRConstraint.ll
  test/CodeGen/X86/2008-04-26-Asm-Optimize-Imm.ll
  test/CodeGen/X86/inline-asm-modifier-n.ll
  test/CodeGen/X86/inline-asm-q-regs.ll
  test/CodeGen/X86/inline-asm-fpstack.ll
  test/CodeGen/X86/2010-07-06-asm-RIP.ll
  test/CodeGen/X86/2009-02-12-InlineAsm-nieZ-constraints.ll
  test/CodeGen/X86/2010-06-15-FastAllocEarlyCLobber.ll
  test/CodeGen/X86/fold-xmm-zero.ll
  test/CodeGen/X86/2008-10-20-AsmDoubleInI32.ll
  test/CodeGen/X86/inline-asm-flag-clobber.ll
  test/CodeGen/X86/inline-asm-x-scalar.ll
  test/CodeGen/X86/2006-07-20-InlineAsm.ll
  test/CodeGen/X86/2007-11-04-rip-immediate-constant.ll
  test/CodeGen/X86/2009-12-01-EarlyClobberBug.ll
  test/CodeGen/X86/multiple-loop-post-inc.ll
  test/CodeGen/X86/inline-asm-stack-realign3.ll
  test/CodeGen/X86/inline-asm.ll
  test/CodeGen/X86/2008-09-18-inline-asm-2.ll
  test/CodeGen/X86/2011-10-11-SpillDead.ll
  test/CodeGen/X86/2006-07-31-SingleRegClass.ll
  test/CodeGen/X86/asm-global-imm.ll
  test/CodeGen/X86/2008-02-20-InlineAsmClobber.ll
  test/CodeGen/X86/inline-asm-tied.ll
  test/CodeGen/X86/asm-block-labels.ll
  test/CodeGen/X86/2008-02-26-AsmDirectMemOp.ll
  test/CodeGen/X86/2007-03-24-InlineAsmPModifier.ll
  test/CodeGen/X86/2007-11-04-LiveVariablesBug.ll
  test/CodeGen/X86/2010-06-28-FastAllocTiedOperand.ll
  test/CodeGen/X86/inline-asm-h.ll
  test/CodeGen/X86/inline-asm-mrv.ll
  test/CodeGen/X86/2010-07-02-asm-alignstack.ll
  test/CodeGen/X86/2007-10-28-inlineasm-q-modifier.ll
  test/CodeGen/X86/2010-06-25-asm-RA-crash.ll
  test/CodeGen/X86/mult-alt-generic-i686.ll
  test/CodeGen/X86/2009-09-19-earlyclobber.ll
  test/CodeGen/Generic/inline-asm-special-strings.ll
  test/CodeGen/Generic/2008-02-20-MatchingMem.ll
  test/CodeGen/Generic/asm-large-immediate.ll
  test/CodeGen/Generic/2007-04-27-InlineAsm-X-Dest.ll
  test/CodeGen/Generic/2007-04-08-MultipleFrameIndices.ll
  test/CodeGen/Generic/mature-mc-support.ll
  test/CodeGen/Generic/inline-asm-mem-clobber.ll
  test/CodeGen/Generic/2007-04-27-LargeMemObject.ll
  test/CodeGen/PowerPC/2007-04-24-InlineAsm-I-Modifier.ll
  test/CodeGen/PowerPC/2007-05-03-InlineAsm-S-Constraint.ll
  test/CodeGen/ARM/arm-modifier.ll
  test/CodeGen/ARM/inlineasm3.ll
  test/CodeGen/ARM/inlineasm-64bit.ll
  test/CodeGen/ARM/mult-alt-generic-arm.ll
  test/CodeGen/ARM/subreg-remat.ll
  test/CodeGen/ARM/crash-O0.ll
  test/CodeGen/ARM/inlineasm-imm-arm.ll
  test/CodeGen/ARM/2009-04-06-AsmModifier.ll
  test/CodeGen/Thumb/inlineasm-imm-thumb.ll
  test/CodeGen/AArch64/inline-asm-modifiers.ll
  test/CodeGen/AArch64/inline-asm-constraints.ll
  lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
  lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp
  lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp
  lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.h
  lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
  lib/MC/MCAsmInfoCOFF.cpp
  lib/MC/MCAsmInfoDarwin.cpp
  lib/MC/MCAsmInfo.cpp
  lib/CodeGen/LLVMTargetMachine.cpp
  lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2686.5.patch
Type: text/x-patch
Size: 42639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140206/f60a9225/attachment.bin>


More information about the llvm-commits mailing list