[PATCH] [AArch64] Add missing PCRel relocations for AArch64 in RuntimeDyldELF
Bradley Smith
bradley.smith at arm.com
Wed Feb 5 06:43:32 PST 2014
Hmm, perhaps the test shouldn't be re-enabled in that case, however I think it may still be worth adding these relocations in, even if it isn't all of them?
================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:459
@@ +458,3 @@
+ // Operation: Page(S+A) - Page(P)
+ uint64_t Result = ((Value + Addend) & ~0xfffU) - (FinalAddress & ~0xfffU);
+
----------------
Tim Northover wrote:
> Shouldn't the constants be ULL? I'd have thought ~0xfffU would be (unsigned)0xfffff000 and then get zero-extended to 64-bits.
Yes you're absolutely right.
http://llvm-reviews.chandlerc.com/D2696
More information about the llvm-commits
mailing list