[PATCH] change llvm configure arc4random presence test to fix broken configuration

[Todd Fiala]

Okay, I'll get this in.


On Tue, Feb 4, 2014 at 7:16 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:

> LGTM.
>
>
> On February 4, 2014 4:40:49 PM PST, Todd Fiala <tfiala at google.com> wrote:
>>
>> Take 2 - this time with the cmake #define name adjusted to match the name
>> change generated by using a different autoconf macro for the arc4random
>> check.
>>
>> Verified by running and building with cmake on Ubuntu 12.04 x86_64 and
>> verifying the variable name generated was correct:
>>
>> ~/work/build4: $ grep -R HAVE_DECL_ARC4RANDOM *
>> CMakeCache.txt:HAVE_DECL_ARC4RANDOM:INTERNAL=
>>
>> How does that look?
>>
>>
>>
>> On Tue, Feb 4, 2014 at 4:20 PM, Todd Fiala <tfiala at google.com> wrote:
>>
>>> Thanks,Peter - I'm working on that now.
>>>
>>>
>>> On Tue, Feb 4, 2014 at 4:12 PM, Peter Collingbourne <peter at pcc.me.uk>wrote:
>>>
>>>> On Tue, Feb 04, 2014 at 04:03:29PM -0800, Todd Fiala wrote:
>>>> > -#if !defined(HAVE_ARC4RANDOM)
>>>> > +#if !defined(HAVE_DECL_ARC4RANDOM) || !HAVE_DECL_ARC4RANDOM
>>>>
>>>> I think you also need to rename the symbol in the CMake scripts
>>>> (cmake/config-ix.cmake
>>>> and include/llvm/Config/config.h.cmake).
>>>>
>>>> Thanks,
>>>> --
>>>> Peter
>>>>
>>>
>>>
>>>
>>> --
>>> Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
>>>
>>
>>
>>
>> --
>> Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
>>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140204/097d4d97/attachment.html>