[PATCH] ARM: Resolve thumb_bl fixup in same MCFragment.
Renato Golin
renato.golin at linaro.org
Tue Feb 4 08:59:21 PST 2014
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:579
@@ -570,4 +578,3 @@
// symbol's thumb-ness to get interworking right.
if (A && ((unsigned)Fixup.getKind() == ARM::fixup_arm_thumb_blx ||
(unsigned)Fixup.getKind() == ARM::fixup_arm_blx ||
----------------
David Peixotto wrote:
> Wouldn't we need to still fall through here if the target symbol is not in the same fragment?
No. The isResolved is false if the fragments are not the same as per code above, so the result is the same.
http://llvm-reviews.chandlerc.com/D2675
BRANCH
fix-thumb-far-jump
ARCANIST PROJECT
llvm
More information about the llvm-commits
mailing list