[llvm] r200762 - Revert r122395, "Fixes file extension for loadable modules on OS X."

NAKAMURA Takumi geek4civic at gmail.com
Tue Feb 4 05:33:14 PST 2014


Author: chapuni
Date: Tue Feb  4 07:33:13 2014
New Revision: 200762

URL: http://llvm.org/viewvc/llvm-project?rev=200762&view=rev
Log:
Revert r122395, "Fixes file extension for loadable modules on OS X."

In trunk, every users assume add_llvm_loadable_module as "loadable module" and no one sets neither SHARED, ... nor also MODULE!
Unfortunately, all loadable modules were linked as not "MODULE" but "SHARED".

If this change caused any regressions, I wish guys to fix it properly. ;)

Modified:
    llvm/trunk/cmake/modules/AddLLVM.cmake

Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=200762&r1=200761&r2=200762&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
+++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue Feb  4 07:33:13 2014
@@ -217,14 +217,7 @@ ${name} ignored.")
     # Add empty "phony" target
     add_custom_target(${name})
   else()
-    llvm_process_sources( ALL_FILES ${ARGN} )
-    if (MODULE)
-      set(libkind MODULE)
-    else()
-      set(libkind SHARED)
-    endif()
-
-    add_library( ${name} ${libkind} ${ALL_FILES} )
+    add_library(${name} MODULE ${ALL_FILES})
     set_output_directory(${name} ${LLVM_RUNTIME_OUTPUT_INTDIR} ${LLVM_LIBRARY_OUTPUT_INTDIR})
     set_target_properties( ${name} PROPERTIES PREFIX "" )
     llvm_update_compile_flags(${name})





More information about the llvm-commits mailing list