[compiler-rt] r200686 - [sanitizer] Resubmit r200683: disable -ffunction-sections.

[Justin Bogner]

Almost. I needed to add -Werror in the check (like you did in r200745).
Committed in r200753.

Thanks for looking at this!

Alexey Samsonov <samsonov at google.com> writes:
> Does r200746 helps with that?
>
> On Tue, Feb 4, 2014 at 1:41 AM, Justin Bogner <mail at justinbogner.com> wrote:
>
>     Evgeniy Stepanov <eugeni.stepanov at gmail.com> writes:
>     > [sanitizer] Resubmit r200683: disable -ffunction-sections.
>     >
>     > Added:
>     >     compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/
>     function-sections-are-bad.cc
>     > (with props)
>     > Modified:
>     >     compiler-rt/trunk/CMakeLists.txt
>     >
>     > Modified: compiler-rt/trunk/CMakeLists.txt
>     > URL:
>     > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev
>     =200686&r1=200685&r2=200686&view=diff=====================================
>     =========================================
>     > --- compiler-rt/trunk/CMakeLists.txt (original)
>     > +++ compiler-rt/trunk/CMakeLists.txt Mon Feb  3 05:16:41 2014
>     > @@ -142,6 +142,7 @@ if (NOT MSVC)
>     >      -fno-stack-protector
>     >      -Wno-gnu  # Variadic macros with 0 arguments for ...
>     >      -fvisibility=hidden
>     > +    -fno-function-sections
>     >      )
>     >    if (NOT COMPILER_RT_DEBUG)
>     >      list(APPEND SANITIZER_COMMON_CFLAGS -O3)
>    
>     This breaks the build with -WERROR when building with clang (unless it's
>     ToT), and spews warnings without -WERROR.
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu
>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> --
> Alexey Samsonov, MSK