[PATCH] Use 16 byte stack alignment for NaCl on ARM, and fix a varargs bug

[Renato Golin]

On 4 February 2014 08:20, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:

> What strategy should be used here? "Align > 4" or "(Align == 8 || Align ==
> 16)"? Too small point details of course..
>

Hi Stepan,

I think this issue is generic to the alignment, as you said (K*Align - 1),
so it should be safe to say (Align > 4) and subtract the current stack size
from it for the pad.

I can't see why the alignment would be bigger than 16, but then again, I
couldn't see why the alignment would be bigger than 8, so... ;)

Finally, (Align > 4) is more expressive than the alternative, and leaves it
clear on which class of conditions the pad must be inserted, rather than on
which examples of the class of conditions we know it should.

Though, it would be good to know what stopped you in the past, as we may be
overlooking it again...

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140204/25949422/attachment.html>