[PATCH] Use 16 byte stack alignment for NaCl on ARM, and fix a varargs bug

[Renato Golin]

On 3 February 2014 21:17, Chandler Carruth <chandlerc at google.com> wrote:

> FWIW, if possible it would be good to split this type of change into two
> patches -- the bug fix, and the change which uncovered it.
>

Hi Chandler,

I don't think this is necessary. Not only the patch has 2 lines, but it's
not uncommon for patches implementing a new feature to have the
corresponding fixes, especially if it's only by introducing the feature
that the "bug" shows up.

This case is even more obvious, since 8 was the maximum alignment and now
it's 16. I think you got distracted by Mark's usage of the "bug" word. ;)

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140203/e965932d/attachment.html>