[llvm] r200606 - MC: Improve the .fill directive's compatibility with GAS

David Majnemer david.majnemer at gmail.com
Mon Feb 3 13:14:06 PST 2014


EmissionSize can be greater than four.

Consider a target which can emit four byte values but not eight byte
values.  We would want to emit two four-byte entities so we cap
EmissionSize.


On Mon, Feb 3, 2014 at 1:00 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> > +      unsigned EmissionSize = PowerOf2Floor(Remaining);
> > +      if (EmissionSize > 4)
> > +        EmissionSize = 4;
>
> Why can't this be an assert(EmissionSize <= 4)?
>
> Please also add a test showing the big endian behavior.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140203/96b289ae/attachment.html>


More information about the llvm-commits mailing list