[PATCH] Patch that implements %hi(sym1 - sym2) and %lo(sym1 - sym2) expressions for MIPS.

[Mark Seaborn]

  LGTM.  When you commit this, you can put "Differential Revision: http://llvm-reviews.chandlerc.com/D2592" in the commit message to link back to the review.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1325
@@ +1324,3 @@
+      if (VK == MCSymbolRefExpr::VK_Mips_ABS_HI)
+        Res = MipsMCExpr::CreateHi(Expr, getContext());
+      else
----------------
Nit: you could do "return MipsMCExpr::CreateHi(...)" here

================
Comment at: test/MC/Mips/hilo-addressing.s:7
@@ +6,3 @@
+
+# RUN: llvm-mc %s -filetype=obj -triple=mipsel-unknown-linux \
+# RUN:  | llvm-readobj -r | FileCheck %s -check-prefix=CHECK-REL
----------------
Can you make this llvm-mc invocation consistent with the previous one?  i.e. "%s" at end, and consistently use or omit "-o -".


http://llvm-reviews.chandlerc.com/D2592