[compiler-rt] r200683 - [sanitizer] Disable -ffunction-sections.

[Evgeniy Stepanov]

Author: eugenis
Date: Mon Feb  3 04:15:08 2014
New Revision: 200683

URL: http://llvm.org/viewvc/llvm-project?rev=200683&view=rev
Log:
[sanitizer] Disable -ffunction-sections.

It breaks when a binary is linked with --gc-sections: parts of sanitizer
interface get thrown away and inaccessible from dlopen-ed libs.

Added:
    compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc   (with props)
Modified:
    compiler-rt/trunk/CMakeLists.txt

Modified: compiler-rt/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=200683&r1=200682&r2=200683&view=diff
==============================================================================
--- compiler-rt/trunk/CMakeLists.txt (original)
+++ compiler-rt/trunk/CMakeLists.txt Mon Feb  3 04:15:08 2014
@@ -142,6 +142,7 @@ if (NOT MSVC)
     -fno-stack-protector
     -Wno-gnu  # Variadic macros with 0 arguments for ...
     -fvisibility=hidden
+    -fno-function-sections
     )
   if (NOT COMPILER_RT_DEBUG)
     list(APPEND SANITIZER_COMMON_CFLAGS -O3)

Added: compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc?rev=200683&view=auto
==============================================================================
--- compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc (added)
+++ compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc Mon Feb  3 04:15:08 2014
@@ -0,0 +1,39 @@
+// Check that --gc-sections does not throw away (or localize) parts of sanitizer
+// interface.
+// RUN: %clang_asan -m64 %s -Wl,--gc-sections -o %t
+// RUN: %clang_asan -m64 %s -DBUILD_SO -fPIC -o %t-so.so -shared
+// RUN: %t 2>&1
+
+#ifndef BUILD_SO
+#include <assert.h>
+#include <dlfcn.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+int main(int argc, char *argv[]) {
+  char path[4096];
+  snprintf(path, sizeof(path), "%s-so.so", argv[0]);
+
+  void *handle = dlopen(path, RTLD_LAZY);
+  if (!handle) fprintf(stderr, "%s\n", dlerror());
+  assert(handle != 0);
+
+  typedef void (*F)();
+  F f = (F)dlsym(handle, "call_rtl_from_dso");
+  printf("%s\n", dlerror());
+  assert(dlerror() == 0);
+  f();
+  
+  dlclose(handle);
+  return 0;
+}
+
+#else // BUILD_SO
+
+#include <sanitizer/msan_interface.h>
+extern "C" void call_rtl_from_dso() {
+  volatile int32_t x;
+  volatile int32_t y = __sanitizer_unaligned_load32((void *)&x);
+}
+
+#endif // BUILD_SO

Propchange: compiler-rt/trunk/lib/asan/lit_tests/TestCases/Linux/function-sections-are-bad.cc
------------------------------------------------------------------------------
    svn:eol-style = LF