[PATCH] PowerPC - Use MCInstrDesc to get instruction size

Hal Finkel hfinkel at anl.gov
Sat Feb 1 22:18:48 PST 2014


----- Original Message -----
> From: "David Wiberg" <dwiberg at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> Sent: Saturday, February 1, 2014 7:46:36 AM
> Subject: Re: [PATCH] PowerPC - Use MCInstrDesc to get instruction size
> 
> 2014-01-26 David Wiberg <dwiberg at gmail.com>:
> > 2014-01-25 Hal Finkel <hfinkel at anl.gov>:
> >> David,
> >>
> >> LGTM, thanks! There is also PPCInstrInfo::GetInstSizeInBytes,
> >> which should also be fixed up. Would you mind taking care of that
> >> one too?
> >
> > Thanks for the review. The attached patch adds the same kind of
> > change
> > for GetInstSizeInBytes too. I do not have commit access.
> >
> > / David
> >
> Ping, patch updated.

r200623, thanks!

 -Hal

> 
> / David
> 
> >>
> >>  -Hal
> >>
> >> ----- Original Message -----
> >>> From: "David Wiberg" <dwiberg at gmail.com>
> >>> To: "llvm-commits" <llvm-commits at cs.uiuc.edu>
> >>> Sent: Saturday, January 25, 2014 12:57:52 PM
> >>> Subject: [PATCH] PowerPC - Use MCInstrDesc to get instruction
> >>> size
> >>>
> >>> Hello,
> >>>
> >>> The attached patch adds a reference to MCInstrInfo to the
> >>> PPCMCCodeEmitter and uses it to determine instruction size when
> >>> encoding instructions instead of using hard-coded values.
> >>>
> >>> / David
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>>
> >>
> >> --
> >> Hal Finkel
> >> Assistant Computational Scientist
> >> Leadership Computing Facility
> >> Argonne National Laboratory
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list