[lld] r200599 - [PECOFF] Add a TODO.
Rui Ueyama
ruiu at google.com
Fri Jan 31 16:26:33 PST 2014
Author: ruiu
Date: Fri Jan 31 18:26:33 2014
New Revision: 200599
URL: http://llvm.org/viewvc/llvm-project?rev=200599&view=rev
Log:
[PECOFF] Add a TODO.
Modified:
lld/trunk/lib/Driver/WinLinkDriver.cpp
Modified: lld/trunk/lib/Driver/WinLinkDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=200599&r1=200598&r2=200599&view=diff
==============================================================================
--- lld/trunk/lib/Driver/WinLinkDriver.cpp (original)
+++ lld/trunk/lib/Driver/WinLinkDriver.cpp Fri Jan 31 18:26:33 2014
@@ -701,6 +701,9 @@ WinLinkDriver::parse(int argc, const cha
// Handle /machine before parsing all the other options, as the target machine
// type affects how to handle other options. For example, x86 needs the
// leading underscore to mangle symbols, while x64 doesn't need it.
+ //
+ // TODO: If /machine option is missing, we probably should take a look at
+ // the magic byte of the first object file to set machine type.
if (llvm::opt::Arg *inputArg = parsedArgs->getLastArg(OPT_machine)) {
StringRef arg = inputArg->getValue();
llvm::COFF::MachineTypes type = stringToMachineType(arg);
More information about the llvm-commits
mailing list