[PATCH] [stack protector] Improved data layout rules, part 4

[Josh Magee]

  See my inline comment in response to the refactoring.  All the rest of the comments look good - I'll make those changes.


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:547
@@ -546,3 +546,3 @@
     Offset += MFI->getLocalFrameSize();
 
     MaxAlign = std::max(Align, MaxAlign);
----------------
Bill Wendling wrote:
> Is this code identical to the one in CodeGen/LocalStackSlotAllocation.cpp? If so, please refactor it.
A large amount of the code in LocalStackSlotAllocation.cpp is identical to PrologEpilogInserter.cpp - there is significant refactoring that can be done there.  It is not easy to draw the line...

I'm happy to refactor the stack-protector stuff out as a first step.  I'm also happy to continue that effort to refactor out much of the duplication in these passes - the duplication always puzzled (and bothered) me a bit.

I'd prefer to do the refactoring as subsequent patches.  Does that sound reasonable?


http://llvm-reviews.chandlerc.com/D2546