[PATCH] MC: Improve the .fill directive's compatibility with GAS

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jan 31 10:59:10 PST 2014


On 31 January 2014 13:46, Jim Grosbach <grosbach at apple.com> wrote:
>
>   Dunno if it's a dealbreaker, but the result with .long directives seems a lot more readable to me. I don't expect (usually) to see .asciz used for anything that's not a string, so this looks really odd.
>
>   In a perfect world, the code would pad out the end of the fill with .short and .byte directives rather than ever using .asciz, but that's probably too much to ask. :)

I guess that could be implemented directly in
MCAsmStreamer::EmitIntValue. That way MCAsmStreamer::EmitValueImpl
would forward to MCAsmStreamer::EmitIntValue instead of
MCStreamer::EmitIntValue. Having said that, I would probably implement
it as an independent patch.



More information about the llvm-commits mailing list