[PATCH] Subclass DynamicTable for each targets to factor out handling of target dependent part of a dynamic table

Simon Atanasyan simon at atanasyan.com
Thu Jan 30 21:22:29 PST 2014


  This time I know the only target needs to override the only dynamic table tag. It is MIPS. Maybe there are other targets with the same requirements but AFAIK x86, x86_64, arm, ppc, hexagon etc do not need such "translation". If we make a complicated design right now we might never get any benefits from it. Moreover we try to invent a complicated design without proper specification. Who know maybe there is an architecture which combines content of two "standard" tags into the single "non-standard" one? Should we support such hypothetical requirements? From the other side, if or when a number of methods like proposed `getGotPltTag()` grow in the future and or we get know about other "non-standard" targets, we will be able to estimate new demands and replace the current simple design.

http://llvm-reviews.chandlerc.com/D2643



More information about the llvm-commits mailing list