[llvm] r200499 - [CMake] llvm_update_compile_flags: Honor LLVM_COMPILE_FLAGS.
NAKAMURA Takumi
geek4civic at gmail.com
Thu Jan 30 14:55:25 PST 2014
Author: chapuni
Date: Thu Jan 30 16:55:25 2014
New Revision: 200499
URL: http://llvm.org/viewvc/llvm-project?rev=200499&view=rev
Log:
[CMake] llvm_update_compile_flags: Honor LLVM_COMPILE_FLAGS.
I accidentally mis-dropped LLVM_COMPILE_FLAGS in r200301. Sorry for that.
Modified:
llvm/trunk/cmake/modules/AddLLVM.cmake
Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=200499&r1=200498&r2=200499&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
+++ llvm/trunk/cmake/modules/AddLLVM.cmake Thu Jan 30 16:55:25 2014
@@ -12,22 +12,27 @@ function(llvm_update_compile_flags name)
set(LLVM_REQUIRES_RTTI ON)
else()
if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
- set(target_compile_flags "${target_compile_flags} -fno-exceptions")
+ list(APPEND LLVM_COMPILE_FLAGS "-fno-exceptions")
elseif(MSVC)
list(APPEND LLVM_COMPILE_DEFINITIONS _HAS_EXCEPTIONS=0)
- set(target_compile_flags "${target_compile_flags} /EHs-c-")
+ list(APPEND LLVM_COMPILE_FLAGS "/EHs-c-")
endif()
endif()
if(NOT LLVM_REQUIRES_RTTI)
list(APPEND LLVM_COMPILE_DEFINITIONS GTEST_HAS_RTTI=0)
if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
- set(target_compile_flags "${target_compile_flags} -fno-rtti")
+ list(APPEND LLVM_COMPILE_FLAGS "-fno-rtti")
elseif (MSVC)
- set(target_compile_flags "${target_compile_flags} /GR-")
+ list(APPEND LLVM_COMPILE_FLAGS "/GR-")
endif ()
endif()
+ # Assume that;
+ # - LLVM_COMPILE_FLAGS is list.
+ # - PROPERTY COMPILE_FLAGS is string.
+ string(REPLACE ";" " " target_compile_flags "${LLVM_COMPILE_FLAGS}")
+
if(update_src_props)
foreach(fn ${sources})
get_filename_component(suf ${fn} EXT)
@@ -399,7 +404,7 @@ function(add_unittest test_suite test_na
endif ()
if (SUPPORTS_NO_VARIADIC_MACROS_FLAG)
- set(LLVM_COMPILE_FLAGS "-Wno-variadic-macros")
+ list(APPEND LLVM_COMPILE_FLAGS "-Wno-variadic-macros")
endif ()
set(LLVM_REQUIRES_RTTI OFF)
More information about the llvm-commits
mailing list