[PATCH] Fix PR18381 - print a minimal diagnostic rather than assert on unresolved .secidx target

Reid Kleckner rnk at google.com
Thu Jan 30 10:54:40 PST 2014


I'd leave the stack trace alone for now.  That's what all other MC errors
do.  If somebody wants to fix that, they can do it later.

For the wording, IMO it'd be more consistent to say that this was an
"undefined symbol".  It's not clear what "couldn't resolve" means, and
"undefined" feels more precise.  Also, we should mention .secidx.

We have other errors like:
          Twine("symbol '") + B->getName() +
              "' can not be undefined in a subtraction expression");

So we could do something like:
Cannot get section of undefined symbol 'bar' in .secidx directive


On Thu, Jan 30, 2014 at 10:46 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> What's the recommended way to get rid of the stacktrace?
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140130/c8805b28/attachment.html>


More information about the llvm-commits mailing list