[PATCH] [sanitizer] Add most ioctls from /usr/include/sound/.

Evgeniy Stepanov eugenis at google.com
Thu Jan 30 10:18:39 PST 2014


  I think you are correct about _IOW and _IOR.
  Please add a test for at least one of these, to see that there is no systematic error here (I realize that testing all of them is hardly possible).
  LGTM


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc:663
@@ -534,3 +662,3 @@
                              unsigned request, void *arg) {
   if (desc->type == ioctl_desc::READ) {
     unsigned size = desc->size ? desc->size : IOC_SIZE(request);
----------------
Why not add READWRITE here in the same commit?


http://llvm-reviews.chandlerc.com/D2659

BRANCH
  msan/ioctl_alsa

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list