[PATCH] XCore target: Handle common linkage
Richard Osborne
richard at xmos.com
Wed Jan 29 10:06:07 PST 2014
Looks good to me otherwise.
================
Comment at: lib/Target/XCore/XCoreAsmPrinter.cpp:102
@@ -101,2 +101,3 @@
OutContext));
- if (GV->hasWeakLinkage() || GV->hasLinkOnceLinkage()) {
+ if (GV->hasWeakLinkage() || GV->hasLinkOnceLinkage()
+ || GV->hasCommonLinkage()) {
----------------
I think LLVM coding style is to split the line after the binary operator, not before.
http://llvm-reviews.chandlerc.com/D2650
More information about the llvm-commits
mailing list