[PATCH] add supporting ASAN instrumentation on FreeBSD platform

Kostya Serebryany kcc at google.com
Tue Jan 28 23:49:08 PST 2014


  That's too many duplicated tests, and they still don't check anything for freebsd except for the triple.

  I'd suggest to create two tests with just one function each, similar to @read_4_bytes in test/Instrumentation/AddressSanitizer/test64.ll
  i.e. a test that checks the shadow offset.

  Ideally, that would be a single test file with two RUN: commands, one for 32-bit and one for 64-bit.
  We now have  a (recently added?) flag -mtriple that passes the triple,
  but I don't know how to pass "target datalayout" in a command line. So, this is a bonus level :)

  Also, why did you place one test in X86 subdir?

http://llvm-reviews.chandlerc.com/D2635



More information about the llvm-commits mailing list