[PATCH] [prototype] Adding line table debug information to LLVM on Windows
Timur Iskhodzhanov
timurrrr at google.com
Tue Jan 28 22:55:02 PST 2014
Sorry for the breakage and not reverting it earlier - I don't think I got
an email about the failure.
How do you recommend me to tweak them?
The default triple on windows shouldn't imply dwarf. I think running these
tests with a -cygwin/-mingw32 triple is reasonable, as it is probably (?)
reasonable to run them with the default triple on non-Windows architectures.
28 янв. 2014 г. 22:23 пользователь "NAKAMURA Takumi" <geek4civic at gmail.com>
написал:
>
> Reverted in r200375. It broke many llvm and clang tests, at least in
> msc17 builder.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
> @@ -195,3 +197,3 @@
> if (MAI->doesSupportDebugInformation()) {
> - DD = new DwarfDebug(this, &M);
> - Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
> + if (Triple(TM.getTargetTriple()).getOS() == Triple::Win32) {
> + Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
> ----------------
> You should tweak more other tests (also in clang/test/CodeGen/ !) when you
> suppressed llvm::DwarfDebug.
>
> You can reproduce such a case with
> LLVM_DEFAULT_TARGET_TRIPLE:=i686-pc-win32
>
>
> http://llvm-reviews.chandlerc.com/D2232
>
http://llvm-reviews.chandlerc.com/D2232
More information about the llvm-commits
mailing list