[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Eric Christopher]

On Jan 28, 2014 10:23 PM, "NAKAMURA Takumi" <geek4civic at gmail.com> wrote:
>
>
>   Reverted in r200375. It broke many llvm and clang tests, at least in
msc17 builder.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198
> @@ -195,3 +197,3 @@
>    if (MAI->doesSupportDebugInformation()) {
> -    DD = new DwarfDebug(this, &M);
> -    Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));
> +    if (Triple(TM.getTargetTriple()).getOS() == Triple::Win32) {
> +      Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),
> ----------------
> You should tweak more other tests (also in clang/test/CodeGen/ !) when
you suppressed llvm::DwarfDebug.
>
> You can reproduce such a case with
LLVM_DEFAULT_TARGET_TRIPLE:=i686-pc-win32
>

Wondering what we think i686-pc-win32 means if not windows?

-eric

>
> http://llvm-reviews.chandlerc.com/D2232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140128/2ff8bedb/attachment.html>