[PATCH] Add support for assigning to . in AsmParser

Saleem Abdulrasool compnerd at compnerd.org
Tue Jan 28 19:51:32 PST 2014


  Aside from Jim's comment (which I think you need to resolve), LGTM.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:2128
@@ +2127,3 @@
+    if (Out.EmitValueToOffset(Value, 0)) {
+      Error(EqualLoc, "expected assembly-time absolute expression in assignment to pseudo-symbol '.'");
+      eatToEndOfStatement();
----------------
Jim Grosbach wrote:
> Other diagnostics for this sort of thing just say "expected absolute expression". Does the additional verbiage here communicate enough useful additional information to be worth diverging?
IMO, the given message here is nicer than "expected absolute expression".


http://llvm-reviews.chandlerc.com/D2625



More information about the llvm-commits mailing list