[PATCH][DAGCombiner] Teach the DAGCombiner how to fold sext/aext/zext of constant build_vectors.

Andrea Di Biagio andrea.dibiagio at gmail.com
Tue Jan 28 05:02:58 PST 2014


Hi Ilia,

Thanks for the reproducible!
I committed revision 200313 to fix the problem you reported.

Please let me know if it now works for you.
If it still doesn't work then I will revert both revision 200313 and
revision 200234.

Thanks,
Andrea

On Tue, Jan 28, 2014 at 11:18 AM, Andrea Di Biagio
<andrea.dibiagio at gmail.com> wrote:
> Hi Ilia,
>
> Sorry for the inconvenience.
> I am currently looking into this.
>
> Andrea
>
> On Tue, Jan 28, 2014 at 10:24 AM, Ilia Filippov <ili.filippov at gmail.com> wrote:
>> Hi Andrea, Nadav
>> It seems that this patch causes llc core dump on the following example:
>>
>> ; ModuleID = 'p.bc'
>> target datalayout = "e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128"
>> target triple = "i386-unknown-linux-gnu"
>>
>> ; Function Attrs: nounwind
>> define <4 x i64> @f_f(<4 x i64> %__mask) #4 {
>> allocas:
>>   %AAA = select <4 x i1> <i1 true, i1 true, i1 false, i1 false>, <4 x i64>
>> %__mask, <4 x i64> <i64 undef, i64 undef, i64 0, i64 0>
>>   ret <4 x i64> %AAA
>> }
>> attributes #4 = { nounwind "target-cpu"="core-avx-i"
>> "target-features"="+avx,+popcnt,+cmov" }
>>
>> Could you please have a look?
>>
>>
>> 2014-01-27 Andrea Di Biagio <andrea.dibiagio at gmail.com>
>>>
>>> Thanks for the review!
>>>
>>> Committed revision 200234.
>>>
>>> On Mon, Jan 27, 2014 at 6:00 PM, Nadav Rotem <nrotem at apple.com> wrote:
>>> > Hi Andrea,
>>> >
>>> > The patch LGTM.
>>> >
>>> > Thanks,
>>> > Nadav
>>> >
>>> > On Jan 27, 2014, at 5:27 AM, Andrea Di Biagio
>>> > <andrea.dibiagio at gmail.com> wrote:
>>> >
>>> >> <patch.diff>
>>> >
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>



More information about the llvm-commits mailing list