[Patch] Provide a stub implementation of PPCTargetMACHOStreamer

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jan 27 14:02:52 PST 2014


On 27 January 2014 16:30, Iain Sandoe <iain at codesourcery.com> wrote:
> Hi,
> Recent tidy-ups have exposed that we need a Target Streamer for ppc-darwin*.
>
> Here is a stub implementation, it's on the TODO to fill in the CPU* info from this.
> cheers

+  virtual void emitTCEntry(const MCSymbol &S) {
+    // Does nothing on Darwin, perhaps a diagnostic would be useful.
+  }

is there a .tc directive at all for ppc macho? That is, will
/usr/bin/as error on it? If so, the correct fix is probably to use a
llvm_unreachable in here and make sure CodeGen doesn't use it when
targeting MachO.

LGTM with that fixed.

Cheers,
Rafael



More information about the llvm-commits mailing list