[PATCH] Add support for assigning to . in AsmParser

Saleem Abdulrasool compnerd at compnerd.org
Mon Jan 27 09:38:45 PST 2014



================
Comment at: lib/MC/MCParser/AsmParser.cpp:2127
@@ +2126,3 @@
+    if (Out.EmitValueToOffset(Value, 0))
+      return Error(EqualLoc, "expected assembly-time absolute expression in assignment to pseudo-symbol '.'");
+    return false;
----------------
Please change this to:

    if (Out.EmitValueToOffset(Value, 0)) {
      Error(EqualLoc, "expected assembly-time absolute expression in assignment to psuedo-symbol '.'");
      eatToEndOfStatement();
    }
    return false;

Error will return true, and then generate a secondary diagnostic improperly otherwise.


http://llvm-reviews.chandlerc.com/D2625



More information about the llvm-commits mailing list