[PATCH] tools: add support for decoding ARM attributes
Renato Golin
renato.golin at linaro.org
Mon Jan 27 05:13:37 PST 2014
Hi Saleem,
Apart from the small comment on the variable name, LGTM.
--renato
================
Comment at: tools/llvm-readobj/ARMAttributeParser.cpp:101
@@ +100,3 @@
+ uint32_t &Offset) {
+ StringRef TagName = ARMBuildAttrs::AttrTypeAsString(Tag, /*TagPrefix*/false);
+
----------------
Same name may introduce conflicts. Please rename the list below:
​static const EnumEntry<unsigned> TagNames[]
http://llvm-reviews.chandlerc.com/D2576
More information about the llvm-commits
mailing list