[llvm] r200034 - Add Constant Hoisting Pass

[Hans Wennborg]

On Fri, Jan 24, 2014 at 5:45 PM, Juergen Ributzka <juergen at apple.com> wrote:
> Hi Hans,
>
> there is a default implementation and the targets are free to override them if they have a better/more accurate cost model. If you look i.e. for the original getIntImmCost method, then you will see that only the ARM and the X86 target provide customized implementations. All other targets just use the default one.

Right. I figured that since ARM overrides the old getIntImmCost()
function, it seemed like an oversight that it wouldn't also want to
override the two new ones, i.e. I assumed costs would be wrong.

Anyway, if this isn't a problem we can just silence the warning with a
using directive or turning it off.

> I didn’t see the warning on my build, but I will look into them.

Thanks for looking into it!

 - Hans

> On Jan 24, 2014, at 5:24 PM, Hans Wennborg <hans at chromium.org> wrote:
>> I've reverted the patch in r200058. If you think that's wrong, feel
>> free to re-apply it, but it seems weird to me that we're adding two
>> new getIntImmCost overloads, and not overriding them in the non-X86
>> targets.